Switch to use Go 1.24+ runtime FIPS support. #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
Jan 7, 2026
|
|
||
| export KUBE_OUTPUT_SUBPATH="_fips_output/local" | ||
| export GOEXPERIMENT="boringcrypto" | ||
| # Runtime FIPS: use GODEBUG=fips140=only instead of compile-time boringcrypto |
Contributor
There was a problem hiding this comment.
I don't think these comments are useful. In general, a comment should cover the current code and implementation details, not historical details that can be looked up in Git history.
The Kubernetes builds are complicated and have a lot of moving parts already, so in this case it might be better to just copy the same binaries into the FIPS and non-FIPS subpackages. It will also help compile times quite a lot.
Add fips-go.conf systemd drop-in that sets GODEBUG=fips140=only for all services in FIPS variants. This enables Go's native FIPS 140-3 mode at runtime, restricting crypto packages to FIPS-approved algorithms. Signed-off-by: Jingwei Wang <[email protected]>
sky1122
force-pushed
the
fips
branch
2 times, most recently
from
9c77ef2 to
cbe3791
Compare
…oringcrypto Remove GOEXPERIMENT=boringcrypto from FIPS builds of kubelet and kube-proxy. FIPS compliance is now handled at runtime via GODEBUG=fips140=only using Go 1.24+ native FIPS 140-3 support. Signed-off-by: Jingwei Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #799
Description of changes:
Switch Kubernetes to use Go 1.24+ runtime FIPS support.
Packaging the
GODEBUG=fips140=onlyconfig file in fips variantsNote: these are the minimal changes for switching Go 1.24+ runtime FIPS support.
The rest of the changes need to be clean up will go to a separate release with the SDK clean up release
Testing done:
Testing with non fips cypher image registry
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.